Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Database external access service feature #126

Merged
merged 5 commits into from
Apr 20, 2018
Merged

Added Database external access service feature #126

merged 5 commits into from
Apr 20, 2018

Conversation

ewoutp
Copy link
Contributor

@ewoutp ewoutp commented Apr 20, 2018 •
edited
Loading

This feature creates a service used to reach the database from outside the k8s cluster.
It supports:

  • type: None for no external access service
  • type: Auto for automatic choice between NodePort & LoadBalancerIP
  • type: NodePort to use a NodePort service
  • type: LoadBalancerIP to use a LoadBalancer service

neunhoef
neunhoef approved these changes Apr 20, 2018
View reviewed changes
Copy link
Member

@neunhoef neunhoef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ewoutp ewoutp merged commit 7ee92ef into master Apr 20, 2018
@ewoutp ewoutp deleted the external-access branch April 20, 2018 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neunhoef neunhoef neunhoef approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewoutp @neunhoef