Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OS-365 : map and test delegation #359

Merged
merged 3 commits into from
Apr 24, 2023
Merged

OS-365 : map and test delegation #359

merged 3 commits into from
Apr 24, 2023

Conversation

Rekard0
Copy link
Contributor

@Rekard0 Rekard0 commented Apr 21, 2023 •
edited
Loading

Description

Task: OS-365

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the test network.

heueristik
heueristik previously approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@heueristik heueristik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. One log statement can be removed. I can re-approve afterwards.

@Rekard0 Rekard0 merged commit 1b40a60 into develop Apr 24, 2023
@brickpop brickpop deleted the f/OS-365_delegation_subgraph branch April 24, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josemarinas josemarinas josemarinas left review comments

@brickpop brickpop brickpop approved these changes

@heueristik heueristik heueristik approved these changes

Assignees
No one assigned
Labels
subgraph
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rekard0 @brickpop @heueristik @josemarinas