Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/multisig setup build2 #339

Merged
merged 13 commits into from
Mar 24, 2023
Merged

Conversation

mathewmeconry
Copy link
Contributor

@mathewmeconry mathewmeconry commented Mar 24, 2023

Description

Code4rena finding: code-423n4/2023-03-aragon-findings#86

  • Adds prepareUpdate() to MultisigSetup
  • Adds check that members length isn't > than uint16 during Multisig initialization
  • Adds tests for Multisig update

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have tested my code on the test network.

heueristik
heueristik previously approved these changes Mar 24, 2023
@mathewmeconry mathewmeconry merged commit 099e5ac into develop Mar 24, 2023
@mathewmeconry mathewmeconry deleted the feature/multisig-setup-build2 branch March 24, 2023 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants