-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Console: Improvement round #1 #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #233 +/- ##
=======================================
Coverage 51.36% 51.36%
=======================================
Files 31 31
Lines 512 512
Branches 60 60
=======================================
Hits 263 263
Misses 249 249 Continue to review full report at Codecov.
|
Evalir
changed the title
Console: improvements for demo
[WIP] Console: improvements for demo
Dec 3, 2020
Evalir
changed the title
[WIP] Console: improvements for demo
Console: Improvement round #1
Dec 3, 2020
While it would be great to update to the latest version of React and all its tooling, there seems to be an issue with typescript versions, react-scripts and the new JSX transform wreaking havoc on the JSX checks. While the issue was supposedly fixed here (facebook/create-react-app#9869), upgrading to react-scripts 4.0.1 doesn't fix the problem. Neither does upgrading AND pinning typescript to 4.0.5 so it doesn't overwrite the tsconfig.json file. Let's wait a few versions ahead for react-scripts so we can be sure this is fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements all changes seen in Delphi Digital's demo, and in #229, namely: