Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A major (performance) update on the submodule: srl-zoo #26

Closed
wants to merge 82 commits into from

Conversation

ncble
Copy link
Collaborator

@ncble ncble commented May 21, 2019

Image rotated by 90 degrees

Image preprocessing

Instead of using specific image preprocessing (mode='imagenet') as

    x[..., 0] -= 0.485
    x[..., 1] -= 0.456
    x[..., 2] -= 0.406
    # Scaling
    x[..., 0] /= 0.229
    x[..., 1] /= 0.224
    x[..., 2] /= 0.225

the mode='tf' that rescale pixel value to [-1,1] is preferable and could avoid unwanted effect when applying training with the other datasets/networks.

@ncble ncble requested a review from araffin May 21, 2019 09:19
@araffin araffin requested a review from kalifou May 21, 2019 09:33
@ncble
Copy link
Collaborator Author

ncble commented Aug 9, 2019

The original version (master) of srl_zoo has 5719 lines of code. My pull-request has already added and removed +4145/-1453 lines of code, thus 5598 lines of code have been modified (~97% of code). There is no need to be merged to the master branch.

@ncble ncble closed this Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants