Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: improved error handling #15

Merged

Conversation

talentedmrjones
Copy link
Contributor

@talentedmrjones talentedmrjones commented Nov 1, 2024

Added

  • new test tests/fail-bad-url.yml

Changed

  • Error handling in general.
    • engine/config.go LoadConfig was exiting directly when the caller was also configured to exit based on the returned error. LoadConfig now just reports the error.
    • engine/test.go was exiting directly, now just reports to engine.Run which reports to root command.
  • root.go
    • fixed cli name
    • now exiting based on result of engine.Run
  • engine/test.go refactored logic of test error handling and reporting

@talentedmrjones talentedmrjones self-assigned this Nov 1, 2024
Copy link
Collaborator

@devon-berta-aquia devon-berta-aquia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@talentedmrjones talentedmrjones merged commit a1bd80b into aquia-inc:main Nov 4, 2024
3 checks passed
@talentedmrjones talentedmrjones deleted the refactor-error-handling branch November 4, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants