-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(azure): add support for azurelinux OVAL #294
Conversation
Thanks for your contribution! While it looks good, we also need to update trivy-db before merging this PR. Otherwise, it also inserts Azure Linux 3.0 into trivy-db as CBL-Mariner 3.0. |
It sounds like separating mariner and azure info in the vuln-list directory will make compatibility between the trivy repos simpler, and potentially allow easier removal of CBL-Mariner in future when 2.0 is EOL? |
I've done that separation now, but happy to revert and update trivy-db to rename mariner/3.0 to azurelinux if you prefer that approach. |
Sounds like a plan. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @tofay
Thanks for your work.
I left some comments on the refactoring.
I also think we can start using Azure Linux
in GH action:
vuln-list-update/.github/workflows/update.yml
Lines 86 to 88 in 80e370d
- if: always() | |
name: CBL-Mariner Vulnerability Data | |
run: ./scripts/update.sh mariner "CBL-Mariner Vulnerability Data" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@knqyf263 take a look, when you have time, please.
Sorry to be late. We're now targeting this support for v0.54.0. I'll review it shortly. |
As part of aquasecurity/trivy#6673, add support for reading the azure linux 3.0 OVAL which resides alongside the cbl-mariner 1.0 and 2.0 OVAL.
I thought it sensible to use the same package in this repo for mariner and azure linux since the OVAL parsing is the same for both.