Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update SARIF report template #935

Merged
merged 7 commits into from
Apr 19, 2021
Merged

Update SARIF report template #935

merged 7 commits into from
Apr 19, 2021

Conversation

yongyan-gh
Copy link
Contributor

@yongyan-gh yongyan-gh commented Apr 9, 2021 •
edited
Loading

Fixes #930

  • Remove character 'v' from start of version string.
  • Update rule name according to .Type value.
  • Update rule id format, remove severity from id to convert to sarif level.
  • Update result location Uri points to file.
  • Add base Uri id.
  • Remove region property for now.

Attached the sarif result generated with these changes: report.zip

@CLAassistant
Copy link

CLAassistant commented Apr 9, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@yongyan-gh yongyan-gh mentioned this pull request Apr 9, 2021
Closed
@yongyan-gh yongyan-gh marked this pull request as ready for review April 12, 2021 08:49
@simar7 simar7 self-requested a review April 12, 2021 16:38
@codecov
Copy link

codecov bot commented Apr 12, 2021 •
edited
Loading

Codecov Report

Merging #935 (e9e3b8e) into main (a00d719) will decrease coverage by 6.16%.
The diff coverage is 53.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #935      +/-   ##
==========================================
- Coverage   68.50%   62.34%   -6.17%     
==========================================
  Files          57       65       +8     
  Lines        2210     2605     +395     
==========================================
+ Hits         1514     1624     +110     
- Misses        564      847     +283     
- Partials      132      134       +2
Impacted Files Coverage Δ
pkg/commands/artifact/config.go 81.81% <ø> (ø)
pkg/commands/artifact/fs.go 0.00% <0.00%> (ø)
pkg/commands/artifact/image.go 0.00% <0.00%> (ø)
pkg/commands/artifact/repository.go 0.00% <0.00%> (ø)
pkg/commands/artifact/run.go 0.00% <0.00%> (ø)
pkg/commands/artifact/wire_gen.go 0.00% <0.00%> (ø)
pkg/commands/client/config.go 79.31% <ø> (ø)
pkg/commands/client/run.go 0.00% <0.00%> (ø)
pkg/commands/client/wire_gen.go 0.00% <0.00%> (ø)
pkg/commands/config/cache.go 100.00% <ø> (ø)
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0518d27...e9e3b8e. Read the comment docs.

@eddynaka
Copy link

@simar7 , can you review it, please?

@simar7
Copy link
Member

simar7 commented Apr 14, 2021 •
edited
Loading

I've assigned it to myself already. I will get to it soon. Thanks for your patience.

simar7
simar7 reviewed Apr 14, 2021
View reviewed changes
pkg/report/writer.go Outdated Show resolved Hide resolved
simar7
simar7 reviewed Apr 14, 2021
View reviewed changes
pkg/report/writer.go Outdated Show resolved Hide resolved
simar7
simar7 reviewed Apr 14, 2021
View reviewed changes
pkg/report/writer.go Outdated Show resolved Hide resolved
simar7
simar7 reviewed Apr 14, 2021
View reviewed changes
pkg/report/writer.go Outdated Show resolved Hide resolved
@simar7 simar7 self-requested a review April 19, 2021 20:34
simar7
simar7 approved these changes Apr 19, 2021
View reviewed changes
Copy link
Member

@simar7 simar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks lgtm!

@simar7 simar7 merged commit 60a4e7e into aquasecurity:main Apr 19, 2021
@yongyan-gh yongyan-gh mentioned this pull request Aug 4, 2021
Closed
@yongyan-gh yongyan-gh changed the title Update SARIF repot template Update SARIF report template Mar 2, 2022
liamg pushed a commit that referenced this pull request Jun 7, 2022
@yongyan-gh
Update SARIF report template (#935)
aae9840 
* Update SARIF repot template

* Update test data sarif.golden

* Fix golangci-lint issue

* Add test cases

* Address review feedbacks

* Inline value in assert statement

* Fix location Uri format issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddynaka eddynaka eddynaka left review comments

@simar7 simar7 simar7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SARIF with Trivy
4 participants
@yongyan-gh @CLAassistant @eddynaka @simar7