Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add note about temporary podman socket #7921

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

Ferenc-
Copy link
Contributor

@Ferenc- Ferenc- commented Nov 14, 2024

Description

Related issues

  • Close #XXX

Related PRs

  • #XXX
  • #YYY

Remove this section if you don't have related PRs.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@Ferenc- Ferenc- requested a review from knqyf263 as a code owner November 14, 2024 16:15
@CLAassistant
Copy link

CLAassistant commented Nov 14, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@knqyf263 knqyf263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this way should be located after the normal way here.

@Ferenc-
Copy link
Contributor Author

Ferenc- commented Nov 15, 2024

I think this way should be located after the normal way here.

@knqyf263 Done.

Copy link
Collaborator

@knqyf263 knqyf263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@DmitriyLewen
Copy link
Contributor

@knqyf263 Is 98506b8 and 98506b8 expected here?

@knqyf263
Copy link
Collaborator

oh... mistake...

@knqyf263 knqyf263 force-pushed the temporary-podman-socket branch from 9d23002 to b076a09 Compare November 18, 2024 07:27
@knqyf263
Copy link
Collaborator

My main branch was broken. Thanks.

@knqyf263 knqyf263 added this pull request to the merge queue Nov 18, 2024
Merged via the queue into aquasecurity:main with commit a5f0ef5 Nov 18, 2024
7 checks passed
@Ferenc- Ferenc- deleted the temporary-podman-socket branch November 18, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants