refactor: use UUID for Packages IDs from pom.xml files.
#7879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitriyLewen
changed the title
pom.xml files.pom.xml files.
knqyf263
reviewed
Dec 24, 2024
| @@ -148,7 +148,8 @@ func (p *Parser) parseRoot(root artifact, uniqModules map[string]struct{}) ([]ft | |||
| if _, ok := uniqModules[art.String()]; ok { | |||
| continue | |||
| } | |||
| uniqModules[art.String()] = struct{}{} | |||
| art.ID = uuid.New() | |||
There was a problem hiding this comment.
I want the output reports to be as reproducible as possible. I'm considering another approach, but I have not yet come up with...
There was a problem hiding this comment.
Do you mean using something like a hash instead of UUID?
There was a problem hiding this comment.
That's one of the options. Regardless of the method, I want the same value to be output as much as possible when scanning the same object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are cases when report contains Packages with same
GAV(GroupID, ArtifactID, version).But these are different packages (see #7824 (comment)).
To avoid confusing and build dependency graph correctly, we need to use
UUIDfor each Package frompom.xmlfiles.This solution also fixes problem with relationships in SBOM formats for this case (see #7824 (comment))
PR blocker - #7889
Related issues
Related PR
workspaceRelationship#7889Checklist