-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: include/exclude dev deps in analyzers #7484
base: main
Are you sure you want to change the base?
refactor: include/exclude dev deps in analyzers #7484
Conversation
pom parser
@DmitriyLewen 2d97700 caused a major regression for us, in that it appears --include-dev-deps was never wired through, and maven test dependencies are therefore included by default. Will it be fixed in this PR? IMO it's worthy of a hotfix as we had to downgrade to stop all of our builds producing hundreds of test CVEs |
Thanks @DmitriyLewen , with the PR it doesn't scan test dependencies by default any more. |
if isIntegrationTestDir(filePath) && !a.includeDevDeps { | ||
return nil, nil | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about moving this check to the Required
function.
But it might not be entirely obvious
This PR is stale because it has been labeled with inactivity. |
Description
Move dev(test) dependencies inclusion/exclusion in analyzers.
See #7476 for more details.
Related issues
Checklist