Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(flag): return error if both --download-db-only and --download-java-db-only are specified #7259

Merged

Conversation

DmitriyLewen
Copy link
Contributor

Description

Trivy doesn't support simultaneous use of the --download-db-only and --download-java-db-only flags.
So in this case we need to return an error.

Example:

➜ trivy image --download-db-only --download-java-db-only
2024-07-30T12:19:15+06:00       FATAL   Fatal error     flag error: db flag error: --download-db-only and --download-java-db-only options can not be specified both

Related discussions

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen self-assigned this Jul 30, 2024
@DmitriyLewen DmitriyLewen marked this pull request as ready for review July 30, 2024 06:47
@DmitriyLewen DmitriyLewen requested a review from knqyf263 as a code owner July 30, 2024 06:47
@knqyf263 knqyf263 added this pull request to the merge queue Jul 30, 2024
Merged via the queue into aquasecurity:main with commit f198cf8 Jul 30, 2024
12 checks passed
@DmitriyLewen DmitriyLewen deleted the refactor-download-db-java-db-both branch July 30, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants