fix(sbom): use package UIDs for uniqueness #7042
Merged
+1,483
−131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The package ID, based on the name and version, is used in some places.
trivy/pkg/sbom/io/encode.go
Line 177 in 137c916
However, it is not globally unique, as there are cases where the same package is installed in different paths. We should use UIDs for this purpose.
Also, added a process to fill in the UIDs for old JSON reports as they don't contain UIDs, and tests for
trivy convert
.Related issues
Checklist