Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump trivy-kubernetes version #7012

Merged
merged 1 commit into from
Jun 27, 2024

Conversation

matheusfm
Copy link
Contributor

@matheusfm matheusfm commented Jun 25, 2024

Description

This PR bumps trivy-kubernetes from 87c0f9c7bcf4 to f39bd949a3ac.

See full diff in compare view

Related issues

Related PRs

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@chen-keinan
Copy link
Contributor

chen-keinan commented Jun 25, 2024

@matheusfm I realize now that bumping trivy-kubernetes v0.6.7-0.20240625124151-899963fa9335 is depend on this pr #6861 that's why tests are failing.

maybe its better that I'll bump latest trivy-kubernetes it on this PR #6861 and close your PR.
the other option is for you to wait for #6861 to be merged and afterwards rebase you branch
wdyt ?

@matheusfm
Copy link
Contributor Author

@chen-keinan
I’m ok with either option, whatever you think is best.
I don’t mind waiting for PR #6861 to be merged and updating my branch afterwards.

@chen-keinan
Copy link
Contributor

@matheusfm you can rebase your branch with upstream now, #6861 has been merged

@matheusfm matheusfm force-pushed the bump-trivy-kubernetes branch from cfe87ce to 74832d8 Compare June 26, 2024 12:21
@matheusfm matheusfm force-pushed the bump-trivy-kubernetes branch from 74832d8 to c49ecae Compare June 26, 2024 12:52
@matheusfm
Copy link
Contributor Author

@chen-keinan
I've updated my branch. Note that now trivy-kubernetes version is being bumped to the latest commit (f39bd949a3ac).

@chen-keinan chen-keinan added this to the v0.53.0 milestone Jun 26, 2024
@chen-keinan
Copy link
Contributor

@knqyf263 please have a look at this PR

@chen-keinan chen-keinan added this pull request to the merge queue Jun 27, 2024
Merged via the queue into aquasecurity:main with commit 9e4927e Jun 27, 2024
12 checks passed
skahn007gl pushed a commit to skahn007gl/trivy that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when scanning a Kubernetes workload or ServiceAccount with an empty item in imagePullSecrets array
3 participants