chore: enable float-compare rule from testifylint #6967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikpivkin
reviewed
Jun 19, 2024
|
I'm curious why do we expect the assertions to have any delta at all? |
|
First, see https://github.com/Antonboom/testifylint?tab=readme-ov-file#float-compare We don’t expect a delta, that’s why I used InEpsilon instead of InDelta . |
Signed-off-by: knqyf263 <[email protected]>
knqyf263
approved these changes
Jun 26, 2024
skahn007gl
pushed a commit
to skahn007gl/trivy
that referenced
this pull request
Jul 23, 2024
Signed-off-by: knqyf263 <[email protected]> Co-authored-by: knqyf263 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
enable and fixes float-compare rule from testifylint