-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: explain how VEX is applied #6864
Conversation
Signed-off-by: knqyf263 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great
|
||
### Applying VEX to Dependency Trees | ||
|
||
Trivy internally generates a dependency tree and applies VEX statements to this graph. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe link to the dependency tree docs for more info?
https://aquasecurity.github.io/trivy/v0.52/docs/configuration/reporting/#show-origins-of-vulnerable-dependencies
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be confusing.
This logic is not related to the dependency tree display.
"vulnerability": {"name": "CVE-XXXX-YYYY"}, | ||
"products": [ | ||
{ | ||
"@id": "pkg:golang/[email protected]", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We check all parents of the dependency tree.
Can we add information that either parent can be used(parent of parent, etc.)?
I mean is that for this case we can choose module-b
or module-a
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added 51e8b4f
|
||
### Applying VEX to Dependency Trees | ||
|
||
Trivy internally generates a dependency tree and applies VEX statements to this graph. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be confusing.
This logic is not related to the dependency tree display.
Signed-off-by: knqyf263 <[email protected]>
4a9024b
to
7ab49ef
Compare
Signed-off-by: knqyf263 <[email protected]>
7ab49ef
to
51e8b4f
Compare
This document should have been part of v0.52.0. I'll backport it to release/v0.52 so v0.52.1 release will update the v0.52 document. |
@aqua-bot backport release/v0.52 |
Signed-off-by: knqyf263 <[email protected]>
Backport PR created: #6879 |
Description
Better describe how VEX is applied in the dependency tree
Related PRs
Remove this section if you don't have related PRs.
Checklist