Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(go): add priority for gobinary module versions from ldflags #6745

Merged
merged 1 commit into from
May 24, 2024
Merged

refactor(go): add priority for gobinary module versions from ldflags #6745

merged 1 commit into from
May 24, 2024

Conversation

DmitriyLewen
Copy link
Contributor

@DmitriyLewen DmitriyLewen commented May 22, 2024 •
edited by knqyf263
Loading

Description

See #6702 (comment)

Related issues

Related PRs

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen self-assigned this May 22, 2024
@DmitriyLewen DmitriyLewen marked this pull request as ready for review May 22, 2024 10:00
@DmitriyLewen DmitriyLewen requested a review from knqyf263 as a code owner May 22, 2024 10:00
@knqyf263 knqyf263 added this pull request to the merge queue May 24, 2024
Merged via the queue into aquasecurity:main with commit 20781e5 May 24, 2024
14 checks passed
@DmitriyLewen DmitriyLewen deleted the fix-gobins/ldflags-version-priority branch May 24, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knqyf263 knqyf263 knqyf263 approved these changes

Assignees

@DmitriyLewen DmitriyLewen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(gobinary): incorrect ldflags parsing when version part has prefix
2 participants
@DmitriyLewen @knqyf263