Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(deps): enable testifylint linter on .*_test.go$ #6688

Merged
merged 1 commit into from
May 16, 2024

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented May 15, 2024

Description

enable testifylint linter on .*_test.go$

It helps applying the best practices with testify use

It applies empty, error-nil and error-is-as rules. Several are excluded to avoid having a too big PR.

The .*_test.go$ has been removed from exclude-files and moved to exclude-rules

@mmorel-35 mmorel-35 changed the title ci(lint): enable testifylint linter on .*_test.go$ ci(deps): enable testifylint linter on .*_test.go$ May 15, 2024
Copy link
Member

@simar7 simar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I briefly went over the changes and it seems reasonable to me. But I'll wait for others to reply.

I haven't used this linter in the past and the runtime is of concern to me.

Copy link
Collaborator

@knqyf263 knqyf263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linters can sometimes be too noisy, so let's introduce it once and see how it goes for a while.

@knqyf263 knqyf263 added this pull request to the merge queue May 16, 2024
Merged via the queue into aquasecurity:main with commit 9d26ae8 May 16, 2024
13 of 15 checks passed
@mmorel-35 mmorel-35 deleted the testifylint branch May 16, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants