Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(misconf): Add support for deprecating a check #6664

Merged
merged 8 commits into from
May 16, 2024
Merged

feat(misconf): Add support for deprecating a check #6664

merged 8 commits into from
May 16, 2024

Conversation

simar7
Copy link
Member

@simar7 simar7 commented May 9, 2024 •
edited
Loading

Description

Add support for deprecating a check.

Related issues

Related PRs

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@simar7 simar7 self-assigned this May 9, 2024
@simar7 simar7 marked this pull request as ready for review May 9, 2024 04:30
@simar7 simar7 requested review from nikpivkin and knqyf263 as code owners May 9, 2024 04:30
@simar7
Copy link
Member Author

simar7 commented May 9, 2024

@nikpivkin I'll implement the support for the --ignore-deprecated-checks in another PR to keep the PRs small. Here's the issue for that #6665

@simar7 simar7 changed the title feat(misconf): Add support for deprecating a check deprecation feat(misconf): Add support for deprecating a check May 9, 2024
@simar7 simar7 mentioned this pull request May 11, 2024
Merged
7 tasks
@simar7 simar7 marked this pull request as draft May 11, 2024 05:21
@simar7 simar7 marked this pull request as ready for review May 14, 2024 01:15
nikpivkin
nikpivkin reviewed May 14, 2024
View reviewed changes
pkg/flag/rego_flags.go
@@ -7,6 +7,11 @@ package flag
// config-policy: "custom-policy/policy"
// policy-namespaces: "user"
var (
IncludeDeprecatedChecksFlag = Flag[bool]{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The config-file.md should be updated.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, updated.

@nikpivkin
Copy link
Contributor

Left a small comment, but lgtm.

@simar7 simar7 requested a review from nikpivkin May 14, 2024 21:48
@simar7 simar7 added this pull request to the merge queue May 16, 2024
Merged via the queue into main with commit 88702cf May 16, 2024
21 checks passed
@simar7 simar7 deleted the add-check-deprecation-support branch May 16, 2024 01:42
@aqua-bot aqua-bot mentioned this pull request May 29, 2024
Merged
@nikpivkin nikpivkin mentioned this pull request Aug 23, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikpivkin nikpivkin nikpivkin approved these changes

@knqyf263 knqyf263 Awaiting requested review from knqyf263 knqyf263 is a code owner

Assignees

@simar7 simar7

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simar7 @nikpivkin