refactor: move artifact types under artifact package to avoid import cycles #6652
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently,
ArtifactReference
is defined in the types package underpkg/fanal/types
, which holds a reference to core.BOM internally. SincePkgIdentifier
is also defined in the types package underpkg/fanal/types
, attempting to usePkgIdentifier
fromcore.BOM
results in a circular dependency. To work around this, a similar struct toPkgIdentifier
is redefined in core.BOM now.This is not ideal. This PR proposes moving
ArtifactReference
to the artifact package underpkg/fanal/artifact
to resolve the circular dependency and enable the reuse ofPkgIdentifier
. Also, it refactors the growing number of package-related structs into a separate file (pkg/fanal/types/package.go
) to improve code readability and maintainability. This PR doesn't change any logic.Checklist