Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add local ImageID to SARIF metadata #6522

Merged
merged 4 commits into from
Jun 19, 2024

Conversation

charlesoxyer
Copy link
Contributor

Description

Currently only the sha256 hash is reported in SARIF for the repoDigest (which is only calculated when the image is pushed to the registry) and not the hash of the local image JSON configuration (Image ID). Adding the imageID to the SARIF output would add a unique identifier for local images.

@charlesoxyer charlesoxyer requested a review from knqyf263 as a code owner April 18, 2024 20:56
@CLAassistant
Copy link

CLAassistant commented Apr 18, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@charlesoxyer charlesoxyer changed the title Add local ImageID to SARIF metadata (feat)Add local ImageID to SARIF metadata Apr 18, 2024
Copy link

This PR is stale because it has been labeled with inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. label Jun 18, 2024
Signed-off-by: knqyf263 <[email protected]>
@knqyf263 knqyf263 changed the title (feat)Add local ImageID to SARIF metadata feat: Add local ImageID to SARIF metadata Jun 19, 2024
@knqyf263 knqyf263 enabled auto-merge June 19, 2024 10:03
@knqyf263 knqyf263 added this pull request to the merge queue Jun 19, 2024
Merged via the queue into aquasecurity:main with commit f144e91 Jun 19, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants