Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(db): check schema version for image name only #6410

Conversation

DmitriyLewen
Copy link
Contributor

@DmitriyLewen DmitriyLewen commented Mar 28, 2024

Description

We add tag (schema version) to trivy-db and trivy-java-db repositories (#6219).
But url can contain : not in image name.
In this case we will not add tag.
See example in #6409.

So we need to check schema version for image name only.

Related issues

Related PRs

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen self-assigned this Mar 28, 2024
@DmitriyLewen DmitriyLewen marked this pull request as ready for review March 28, 2024 04:55
@DmitriyLewen DmitriyLewen requested a review from knqyf263 as a code owner March 28, 2024 04:55
Signed-off-by: knqyf263 <[email protected]>
@knqyf263 knqyf263 added this pull request to the merge queue Apr 2, 2024
Merged via the queue into aquasecurity:main with commit 8baccd7 Apr 2, 2024
12 checks passed
@DmitriyLewen DmitriyLewen deleted the fix-db-javadb/check-schema-ver-only-for-image-name branch April 19, 2024 06:08
fl0pp5 pushed a commit to altlinux/trivy that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing schema-version for download java-db in trivy 0.50.1 if repo url contains :
2 participants