Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING: support exclude kinds/namespaces and include kinds/namespaces #6323

Conversation

chen-keinan
Copy link
Contributor

@chen-keinan chen-keinan commented Mar 14, 2024

@chen-keinan chen-keinan force-pushed the feat/support-exclude-include-kinds-namespaces branch from 278c441 to 4e0f136 Compare March 14, 2024 12:14
@chen-keinan chen-keinan changed the title feat: support exclude kinds/namespaces and include kinds/namespaces feat: support exclude kinds/namespaces and include kinds/namespaces Mar 17, 2024
@chen-keinan chen-keinan marked this pull request as ready for review March 18, 2024 14:43
@chen-keinan chen-keinan requested a review from knqyf263 as a code owner March 18, 2024 14:43
@chen-keinan chen-keinan requested a review from simar7 April 4, 2024 15:43
@chen-keinan chen-keinan force-pushed the feat/support-exclude-include-kinds-namespaces branch from 7a7ce26 to cea4434 Compare April 8, 2024 08:18
@chen-keinan chen-keinan changed the title feat: support exclude kinds/namespaces and include kinds/namespaces BREAKING: support exclude kinds/namespaces and include kinds/namespaces Apr 8, 2024
@chen-keinan chen-keinan force-pushed the feat/support-exclude-include-kinds-namespaces branch from 53280e0 to 978593d Compare April 8, 2024 13:45
Copy link
Collaborator

@knqyf263 knqyf263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to update the document, right?
https://aquasecurity.github.io/trivy/v0.50/docs/target/kubernetes/

@chen-keinan chen-keinan force-pushed the feat/support-exclude-include-kinds-namespaces branch from 73be71f to 2cedc68 Compare April 15, 2024 11:03
@chen-keinan chen-keinan force-pushed the feat/support-exclude-include-kinds-namespaces branch from fdb0c84 to 1d867e5 Compare April 24, 2024 11:25
pkg/k8s/commands/run.go Outdated Show resolved Hide resolved
@simar7
Copy link
Member

simar7 commented Apr 26, 2024

@chen-keinan reviewed the latest changes, left one comment.

@chen-keinan chen-keinan force-pushed the feat/support-exclude-include-kinds-namespaces branch 2 times, most recently from dae4206 to 67de675 Compare April 26, 2024 06:07
@knqyf263
Copy link
Collaborator

@chen-keinan Are you planning to update the doc?
#6323 (review)

@chen-keinan
Copy link
Contributor Author

@chen-keinan Are you planning to update the doc? #6323 (review)

there is a specific PR #6465 for docs

@knqyf263
Copy link
Collaborator

I think it's better to include the document update regarding including/excluding in this PR. It makes reverting/blaming easier. What do you think? It may be okay this time, but IMHO, it is generally better. It is common to forget to update the documentation and unintentionally end up with a different PR 😄

@chen-keinan
Copy link
Contributor Author

chen-keinan commented Apr 26, 2024

I think it's better to include the document update regarding including/excluding in this PR. It makes reverting/blaming easier. What do you think? It may be okay this time, but IMHO, it is generally better. It is common to forget to update the documentation and unintentionally end up with a different PR 😄

@knqyf263 the docs PR is for all experience changes not just for this one , that why we make it in a separate PR.
and all PRs together is part of same epic #5745

@chen-keinan chen-keinan force-pushed the feat/support-exclude-include-kinds-namespaces branch from 67de675 to f538bf3 Compare April 26, 2024 11:24
@knqyf263
Copy link
Collaborator

Anyway, it's already approved by Simar. You can merge whenever.

@chen-keinan chen-keinan added this pull request to the merge queue Apr 27, 2024
Merged via the queue into aquasecurity:main with commit 060d0bb Apr 27, 2024
17 checks passed
@chen-keinan chen-keinan deleted the feat/support-exclude-include-kinds-namespaces branch April 27, 2024 14:52
fl0pp5 pushed a commit to altlinux/trivy that referenced this pull request May 6, 2024
fl0pp5 added a commit to altlinux/trivy that referenced this pull request May 28, 2024
@afdesk afdesk mentioned this pull request Sep 4, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants