-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING: support exclude kinds/namespaces
and include kinds/namespaces
#6323
BREAKING: support exclude kinds/namespaces
and include kinds/namespaces
#6323
Conversation
278c441
to
4e0f136
Compare
kinds/namespaces
and include kinds/namespaces
7a7ce26
to
cea4434
Compare
kinds/namespaces
and include kinds/namespaces
kinds/namespaces
and include kinds/namespaces
53280e0
to
978593d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to update the document, right?
https://aquasecurity.github.io/trivy/v0.50/docs/target/kubernetes/
73be71f
to
2cedc68
Compare
fdb0c84
to
1d867e5
Compare
@chen-keinan reviewed the latest changes, left one comment. |
dae4206
to
67de675
Compare
@chen-keinan Are you planning to update the doc? |
there is a specific PR #6465 for docs |
I think it's better to include the document update regarding including/excluding in this PR. It makes reverting/blaming easier. What do you think? It may be okay this time, but IMHO, it is generally better. It is common to forget to update the documentation and unintentionally end up with a different PR 😄 |
@knqyf263 the docs PR is for all experience changes not just for this one , that why we make it in a separate PR. |
Signed-off-by: chenk <[email protected]>
Signed-off-by: chenk <[email protected]>
Signed-off-by: chenk <[email protected]>
Signed-off-by: chenk <[email protected]>
Signed-off-by: chenk <[email protected]>
Signed-off-by: chenk <[email protected]>
67de675
to
f538bf3
Compare
Anyway, it's already approved by Simar. You can merge whenever. |
…paces` (aquasecurity#6323) Signed-off-by: chenk <[email protected]>
…paces` (aquasecurity#6323) Signed-off-by: chenk <[email protected]>
Description
support exclude kinds/namespaces and include kinds/namespaces
Related issues
--include-namespaces
and--exclude-namespaces
#6195--include-kinds
and--exclude-kinds
#6196cluster
andall
args and unused flags #6467Checklist