Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(java): add support for fetching packages from repos mentioned in pom.xml #6171

Merged
merged 6 commits into from
Feb 22, 2024
+286 −96
Merged

feat(java): add support for fetching packages from repos mentioned in pom.xml #6171

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b425810
Issue: #286
renypaul Feb 21, 2024
a3d3269
Fix linting error
renypaul Feb 21, 2024
651fcff
refactor(pom): check servers for repositories when parsing pom
DmitriyLewen Feb 21, 2024
e081fcb
Removed duplicate code
renypaul Feb 21, 2024
f9c31dc
Refinments
renypaul Feb 21, 2024
77df461
fix linter error
DmitriyLewen Feb 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions pkg/dependency/parser/java/pom/parse.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,10 +94,6 @@ func (p *parser) Parse(r dio.ReadSeekerAt) ([]types.Library, []types.Dependency,
content: content,
}

remoteRepositories := root.repositories(p.servers)
// Add central maven repository or repositories obtained using `WithRemoteRepos` function.
p.remoteRepositories = append(remoteRepositories, p.remoteRepositories...)

DmitriyLewen marked this conversation as resolved.
Show resolved Hide resolved
// Analyze root POM
result, err := p.analyze(root, analysisOptions{lineNumber: true})
if err != nil {
Expand Down
Loading