-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(deps): Merge pkg/specs
from trivy-policies into trivy
#6021
Conversation
go.mod
Outdated
@@ -41,7 +41,7 @@ require ( | |||
github.com/cheggaaa/pb/v3 v3.1.4 | |||
github.com/containerd/containerd v1.7.11 | |||
github.com/csaf-poc/csaf_distribution/v3 v3.0.0 | |||
github.com/docker/docker v24.0.7+incompatible | |||
github.com/docker/docker v25.0.0+incompatible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a need to upgrade the docker version? oras.land/oras-go
is not compatible with this version.
After some further researching I don't think merging this in is a good idea at the moment. We will not eliminate the dependence of trivy on trivy-policies (which was one of the goals with this PR) and compliance specs to me feel a better fit to remain with the checks. If things change in the future, we can reevaluate this decision. |
Description
Merge
pkg/specs
from trivy-policies into trivy and remove trivy's dependence on trivy-policies.This PR is stacked onto #6005
Related issues
trivy-iac
into Trivy #5626Stacked PRs
Checklist