-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli): inconsistent behavior across CLI flags, environment variables, and config files #5843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: knqyf263 <[email protected]>
Signed-off-by: knqyf263 <[email protected]>
knqyf263
force-pushed
the
fix/validate_envs
branch
from
December 31, 2023 09:58
f10d5d1
to
aed23be
Compare
Signed-off-by: knqyf263 <[email protected]>
knqyf263
force-pushed
the
fix/validate_envs
branch
from
January 6, 2024 06:40
6d33016
to
554d6fc
Compare
@naortalmor1 @tonaim I believe it requires small changes on your end, but please let me know if it has a big impact. We'll consider another approach in that case. |
DmitriyLewen
reviewed
Jan 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Left nit comment.
DmitriyLewen
approved these changes
Jan 15, 2024
Signed-off-by: knqyf263 <[email protected]>
knqyf263
force-pushed
the
fix/validate_envs
branch
from
January 29, 2024 08:36
56cc26e
to
3b19e13
Compare
@naortalmor1 @tonaim No comments? Can I push on this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In a recent update to Trivy, we introduced validation and alias functionalities for CLI flags. However, we realized that these enhancements had not been uniformly applied to other configuration methods, specifically environment variables and the configuration file (trivy.yaml). This PR addresses this oversight by extending the validation and alias features across all configuration settings, ensuring consistency and improved usability.
To facilitate this integration, we've added a
Parse()
method. This method is designed to be called before accessing values through theValue()
method, mirroring the interface pattern found in the Go's standardflag
package (flag package documentation). This addition ensures that value retrieval does not result in errors and that the parsing process is streamlined across different settings.Additionally, we've refactored the handling of default flag values. Previously, the logic was branched based on the type of the
Default
field of each flag. We've now shifted this approach to leverage Go's generics, allowing for a more explicit and type-safe representation of default values.Related issues
--scanners
aliases across CLI flags, environment variables, and config files #5803Checklist