Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow mapfs to open dirs #3867

Merged
merged 2 commits into from
Mar 19, 2023
Merged

Conversation

knqyf263
Copy link
Collaborator

@knqyf263 knqyf263 commented Mar 19, 2023

Description

mapfs.Open() should work with directories.

A File provides access to a single file. The File interface is the minimum implementation required of the file. Directory files should also implement ReadDirFile. A file may implement io.ReaderAt or io.Seeker as optimizations.

https://pkg.go.dev/io/fs#File

This is a leftover task from #3654. This PR adds support for directories that implement ReadDirFile.

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@knqyf263 knqyf263 self-assigned this Mar 19, 2023
@knqyf263 knqyf263 marked this pull request as ready for review March 19, 2023 10:37
@knqyf263 knqyf263 requested a review from chen-keinan March 19, 2023 10:37
@knqyf263 knqyf263 merged commit 9e4b57f into aquasecurity:main Mar 19, 2023
@knqyf263 knqyf263 deleted the support_dir branch March 19, 2023 11:33
atombrella pushed a commit to atombrella/trivy that referenced this pull request Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants