Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docker): build healthcheck command when building dockerfile from image config #3831

Merged

Conversation

DmitriyLewen
Copy link
Contributor

Description

There are cases when HEALTHCHECK in image config doesn't have /bin/sh prefix.
e.g.
Dockerfile:

FROM alpine

HEALTHCHECK --interval=10s --timeout=3s CMD curl --fail http://localhost:3000 || exit 1 

Image history:

➜ docker history 3814 
IMAGE          CREATED        CREATED BY                                      SIZE      COMMENT
b3bcbd9f64be   7 months ago   HEALTHCHECK &{["CMD-SHELL" "curl --fail http…   0B        buildkit.dockerfile.v0
<missing>      7 months ago   /bin/sh -c #(nop)  CMD ["/bin/sh"]              0B        
<missing>      7 months ago   /bin/sh -c #(nop) ADD file:2a949686d9886ac7c…   5.54MB  

We are currently skipping this line and getting a false positive.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen self-assigned this Mar 14, 2023
@DmitriyLewen DmitriyLewen marked this pull request as ready for review March 14, 2023 06:54
@DmitriyLewen DmitriyLewen requested a review from knqyf263 as a code owner March 14, 2023 06:54
@knqyf263 knqyf263 merged commit 3987a67 into aquasecurity:main Mar 14, 2023
@DmitriyLewen DmitriyLewen deleted the fix/healhcheck-for-img-conf branch March 14, 2023 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker image compliance scan, docker-cis: false positives
2 participants