Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(license): disable jar analyzer for licence scan only #3780

Merged
merged 4 commits into from
Mar 7, 2023
Merged

fix(license): disable jar analyzer for licence scan only #3780

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6b131d0
disable languages without licenses when only license scanner is enabled
DmitriyLewen Mar 7, 2023
2074fc7
add sbom format check to disable languages without licenses
DmitriyLewen Mar 7, 2023
52fec50
disable only jar analyzer
DmitriyLewen Mar 7, 2023
7082919
fix typo
DmitriyLewen Mar 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions pkg/commands/artifact/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,6 +494,15 @@ func disabledAnalyzers(opts flag.Options) []analyzer.Type {
analyzers = append(analyzers, analyzer.TypeLicenseFile)
}

// Parsing jar files requires Java-db client
// But we don't create client if vulnerability analysis is disabled and SBOM format is not used
// We need to disable jar analyzer to avoid errors
// TODO disable all languages that don't contain license information for this case
if opts.Scanners.Enabled(types.LicenseScanner) && !opts.Scanners.Enabled(types.VulnerabilityScanner) &&
!slices.Contains(report.SupportedSBOMFormats, opts.Format) {
analyzers = append(analyzers, analyzer.TypeJar)
}

// Do not perform misconfiguration scanning on container image config
// when it is not specified.
if !opts.ImageConfigScanners.Enabled(types.MisconfigScanner) {
Expand Down