feat(go): support dependency graph and show only direct dependencies in the tree #3691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| modPath := filepath.Join(modDir, "go.mod") | ||
| f, err := os.Open(modPath) | ||
| if errors.Is(err, fs.ErrNotExist) { | ||
| log.Logger.Debugf("go.mod not found: %s", pkgID) |
There was a problem hiding this comment.
This log message can be confusing. Users may not be aware that we are scanning $GOPATH/pkg/mod directory.
Maybe write something like this:
%s doesn't use Go modules
pkg/report/table/vulnerability.go
Outdated
Comment on lines
210
to
212
| if depth < 1 { | ||
| branch := topItem.AddBranch(parent.ID) | ||
| addParents(branch, parent, parentMap, ancestors, seen, depth+1) |
There was a problem hiding this comment.
looks like it is not possible or am i missing something?
There was a problem hiding this comment.
You're right. I wanted to support --dependency-depth so the depth can be configured. But I eventually changed my mind because it could be too much at the moment. I'll remove it.
DmitriyLewen
approved these changes
Feb 28, 2023
knqyf263
changed the title
knqyf263
changed the title
DmitriyLewen
approved these changes
Feb 28, 2023
7 tasks
atombrella
pushed a commit
to atombrella/trivy
that referenced
this pull request
Mar 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related PRs
Checklist