fix(image): fix problem with open jar files #3516
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knqyf263
reviewed
Feb 3, 2023
pkg/fanal/artifact/image/image.go
Outdated
| } | ||
| return digest, rc, nil | ||
| return digest, size, rc, nil |
There was a problem hiding this comment.
I think we can return the cached layer here. Also, we should always cache layers when --slow is passed.
There was a problem hiding this comment.
In addition, cachedFile is no longer needed.
DmitriyLewen
changed the title
|
These fixes have been added to the following PRs: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes for following error:
PROTOCOL_ERROR; received from peer- Increase timeout for getting remote image to fixunexpected EOF- Save layers smaller than 50MB to files and use this to parse files.Related issues
Checklist