Integration tests for docker mode #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Simarpreet Singh <[email protected]>
Signed-off-by: Simarpreet Singh <[email protected]>
simar7
changed the title
knqyf263
reviewed
Dec 18, 2019
Signed-off-by: Simarpreet Singh <[email protected]>
simar7
force-pushed
the
integration-tests-docker-engine
branch
from
5680cd8 to
0bc1c75
Compare
Signed-off-by: Simarpreet Singh <[email protected]>
…rity/trivy into integration-tests-docker-engine
simar7
force-pushed
the
integration-tests-docker-engine
branch
4 times, most recently
from
04c8e0d to
f875ef8
Compare
Signed-off-by: Simarpreet Singh <[email protected]>
simar7
force-pushed
the
integration-tests-docker-engine
branch
from
f875ef8 to
8a9293a
Compare
knqyf263
reviewed
Dec 19, 2019
Signed-off-by: Simarpreet Singh <[email protected]>
Signed-off-by: Simarpreet Singh <[email protected]>
Signed-off-by: Simarpreet Singh <[email protected]>
…rity/trivy into integration-tests-docker-engine
|
@knqyf263 I added four different versions of docker setups here 923bd79 keep in mind each of them takes on average ~4min to complete. I picked these versions because they are evenly spaced in the supported versions list. Maybe we can add more? Keep in mind we're only limited to 4x jobs running in parallel on circleci. Currently it's 1 for unit test and 4 for integration-tests that get run on each push. Also there's a 2500 credit limit (not sure how this actually boils down). |
|
Interestingly enough you can see some of the docker versions currently fail with the version of the client we're using 😰 https://circleci.com/workflow-run/61cb32c7-de96-4cdc-a34a-5b12b50d92cc One example: |
|
Hmm... It's weird as the test passes with 17.03.0-ce. I wonder if the maximum client is not implemented in 17.03.0-ce. So, our integration tests may work only with 18.09.03 in CircleCI. For now, it seems better that we give up running integration tests with multiple Docker Engine and just run them with 18.09.03. |
…uasecurity/trivy into integration-tests-docker-engine
knqyf263
approved these changes
Dec 26, 2019
GuaoGuao
pushed a commit
to GuaoGuao/trivy
that referenced
this pull request
Jun 24, 2020
* wip: run trivy after adding image Signed-off-by: Simarpreet Singh <[email protected]> * integration: Add an integration test for docker mode Signed-off-by: Simarpreet Singh <[email protected]> * integration: Add error checks for docker_engine_test Signed-off-by: Simarpreet Singh <[email protected]> * circleci: add specific docker version Signed-off-by: Simarpreet Singh <[email protected]> * circleci: add specific docker version Signed-off-by: Simarpreet Singh <[email protected]> * docker_engine_test: Add a sad path Signed-off-by: Simarpreet Singh <[email protected]> * circleci: Add docker_version by param Signed-off-by: Simarpreet Singh <[email protected]> * circleci: Add more docker versions Signed-off-by: Simarpreet Singh <[email protected]> * test(integration): remove old docker versions * chore(ci): add requires Co-authored-by: Teppei Fukuda <[email protected]>
liamg
pushed a commit
that referenced
this pull request
Jun 7, 2022
* wip: run trivy after adding image Signed-off-by: Simarpreet Singh <[email protected]> * integration: Add an integration test for docker mode Signed-off-by: Simarpreet Singh <[email protected]> * integration: Add error checks for docker_engine_test Signed-off-by: Simarpreet Singh <[email protected]> * circleci: add specific docker version Signed-off-by: Simarpreet Singh <[email protected]> * circleci: add specific docker version Signed-off-by: Simarpreet Singh <[email protected]> * docker_engine_test: Add a sad path Signed-off-by: Simarpreet Singh <[email protected]> * circleci: Add docker_version by param Signed-off-by: Simarpreet Singh <[email protected]> * circleci: Add more docker versions Signed-off-by: Simarpreet Singh <[email protected]> * test(integration): remove old docker versions * chore(ci): add requires Co-authored-by: Teppei Fukuda <[email protected]>
liamg
pushed a commit
that referenced
this pull request
Jun 7, 2022
liamg
pushed a commit
that referenced
this pull request
Jun 7, 2022
josedonizetti
pushed a commit
to josedonizetti/trivy
that referenced
this pull request
Jun 24, 2022
…apters test: add tests for aws sns tf adapters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces integrations tests for docker mode.
Addresses #325
Signed-off-by: Simarpreet Singh [email protected]