Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(java): the project props take precedence over the parent's props #3320

Merged
merged 3 commits into from
Mar 9, 2023
Merged

fix(java): the project props take precedence over the parent's props #3320

merged 3 commits into from
Mar 9, 2023

Conversation

DmitriyLewen
Copy link
Contributor

@DmitriyLewen DmitriyLewen commented Dec 19, 2022 •
edited by knqyf263
Loading

Description

See #157

Related issues

Related PRs

Checklist

  • [x I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen changed the title fix(pom): use props from child in parent fix(java): use props from child in parent in pom.xml files Dec 19, 2022
@DmitriyLewen DmitriyLewen self-assigned this Dec 19, 2022
@github-actions
Copy link

This PR is stale because it has been labeled with inactivity.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. label Feb 19, 2023
@DmitriyLewen DmitriyLewen removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and will be auto-closed. label Feb 20, 2023
@knqyf263 knqyf263 changed the title fix(java): use props from child in parent in pom.xml files fix(java): the project props take precedence over the parent's props Mar 9, 2023
@knqyf263 knqyf263 marked this pull request as ready for review March 9, 2023 12:32
@knqyf263 knqyf263 self-requested a review as a code owner March 9, 2023 12:32
@knqyf263 knqyf263 merged commit f830763 into main Mar 9, 2023
@knqyf263 knqyf263 deleted the fix/use-props-from-child-in-parent-pom branch March 9, 2023 17:25
@knqyf263
Copy link
Collaborator

knqyf263 commented Mar 9, 2023

It will be included in v0.38.3, which is planned to be released early next week.

atombrella pushed a commit to atombrella/trivy that referenced this pull request Mar 25, 2023
@DmitriyLewen @knqyf263 @atombrella
fix(java): the project props take precedence over the parent's props (a…
1881b23 
…quasecurity#3320)

Co-authored-by: knqyf263 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knqyf263 knqyf263 knqyf263 approved these changes

Assignees

@DmitriyLewen DmitriyLewen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Maven dependencies not resolved correctly during filesystem scan - properties
2 participants
@DmitriyLewen @knqyf263