fix(misconf): skip broken scans #2396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knqyf263
reviewed
Jun 27, 2022
pkg/fanal/handler/misconf/misconf.go
Outdated
| @@ -236,7 +237,8 @@ func (h misconfPostHandler) Handle(ctx context.Context, result *analyzer.Analysi | |||
| for t, scanner := range h.scanners { | |||
| results, err := scanner.ScanFS(ctx, mapMemoryFS[t], ".") | |||
| if err != nil { | |||
| return xerrors.Errorf("scan config error: %w", err) | |||
| log.Logger.Errorf("scan %q was broken with error: %v", scanner.Name(), err) | |||
There was a problem hiding this comment.
Can we skip only invalid content?
knqyf263
approved these changes
Jun 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sometime customer's data contains broken json/yaml files and
trivystops working by such errors.https://github.com/aquasecurity/defsec/blob/e02f93a8b84888a32f912a6caf0932daecee1cd9/pkg/scanners/cloudformation/parser/parser.go#L133-L141
we should show a message about broken files and run other scan.
Related issues
Checklist