BREAKING: disable JAR detection in fs/repo scanning #1512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreyLevchenko
suggested changes
Dec 24, 2021
modify language specific Packages to include pom.xml
AndreyLevchenko
approved these changes
Dec 24, 2021
liamg
pushed a commit
that referenced
this pull request
Jun 7, 2022
Co-authored-by: Andrey Levchenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Trivy looks for JAR files even in filesystem and repository scanning, though it should be only in container image scanning. It is no longer necessary as
pom.xmlis supported now.Before:
After
Blockers
go.modafter this PR gets merged.Notes
JAR scanning is disabled here.
trivy/pkg/commands/artifact/fs.go
Line 34 in 1c9ccb5
trivy/pkg/commands/artifact/repository.go
Line 38 in 1c9ccb5