Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitLab CI integration documentation #1168

Merged
merged 1 commit into from
Aug 8, 2021

Conversation

thiago-gitlab
Copy link
Contributor

@thiago-gitlab thiago-gitlab commented Aug 5, 2021

This is a suggestion to use the native integration, which is a lot simpler than the custom configurations currently recommended in the documentation.

I considered removing them altogether but thought it was best to let a maintainer weight-in before doing so.

@CLAassistant
Copy link

CLAassistant commented Aug 5, 2021

CLA assistant check
All committers have signed the CLA.

@thiago-gitlab
Copy link
Contributor Author

@knqyf263, could you please let me know your thoughts on this?

@knqyf263
Copy link
Collaborator

knqyf263 commented Aug 5, 2021

@thiago-gitlab Thanks! Is it possible to use the integration for free? I thought the feature was provided only for ultimate users.

Recommend the native GitLab integration.
@thiago-gitlab
Copy link
Contributor Author

@knqyf263 🤦🏽‍♂️ of course! It is an ultimate feature :(. I'm sorry about missing that!

While the feature check is in the template itself ($GITLAB_FEATURES =~ /\bcontainer_scanning\b/) and can be easily removed, we might decide to move the check into the analyzer image, so it's definitely not safe to recommend this approach.

I've adjusted my suggestion to account for this. My intent is not to use Trivy's docs to upsell GitLab, so please feel free to close this MR if you think the information is not useful to Trivy users.

Copy link
Collaborator

@knqyf263 knqyf263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know the GitLab Ultimate feature even for OSS users.

@knqyf263 knqyf263 merged commit 8db9b6a into aquasecurity:main Aug 8, 2021
@thiago-gitlab thiago-gitlab deleted the patch-1 branch August 8, 2021 21:02
liamg pushed a commit that referenced this pull request Jun 7, 2022
Recommend the native GitLab integration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants