Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(misconf): ssl_mode support for GCP SQL DB instance #7564

Merged
merged 1 commit into from
Oct 17, 2024
Merged

feat(misconf): ssl_mode support for GCP SQL DB instance #7564

merged 1 commit into from
Oct 17, 2024

Conversation

nikpivkin
Copy link
Contributor

@nikpivkin nikpivkin commented Sep 20, 2024 •
edited
Loading

Description

This PR adds support for the ssl_mode attribute. The check will be fixed in trivy-checks.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@nikpivkin nikpivkin marked this pull request as ready for review September 25, 2024 03:29
@nikpivkin nikpivkin requested a review from simar7 as a code owner September 25, 2024 03:29
@fredrikaverpil fredrikaverpil mentioned this pull request Oct 10, 2024
Merged
@simar7 simar7 added this pull request to the merge queue Oct 17, 2024
Merged via the queue into aquasecurity:main with commit 2eaa17e Oct 17, 2024
13 checks passed
@aqua-bot aqua-bot mentioned this pull request Oct 17, 2024
Merged
@nikpivkin nikpivkin deleted the gcp-sql-ssl-mode branch October 30, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simar7 simar7 simar7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikpivkin @simar7