-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(nodejs): detect direct dependencies when using latest
version for files yarn.lock
+ package.json
#7110
fix(nodejs): detect direct dependencies when using latest
version for files yarn.lock
+ package.json
#7110
Conversation
dependencies: | ||
ms "2.1.2" | ||
|
||
js-tokens@npm:latest: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is it latest
? package.json specifies "js-tokens": "^9.0.0"
. I thought this line would be js-tokens@^9.0.0
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated this manually to test that new logic worked correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to keep using an original file as much as possible so we can understand how it actually works.
Also, instead of using latest
in the package ID, what if we return package patterns somehow and do an exact match? Or, we may want to pass package.json to the yarn lock parser.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better to keep using an original file as much as possible so we can understand how it actually works.
okay, i will remove this.
Also, instead of using latest in the package ID, what if we return package patterns somehow and do an exact match? Or, we may want to pass package.json to the yarn lock parser.
Hm... i will think about this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what if we return package patterns somehow and do an exact match
@knqyf263 I implemented your idea. Take a look, when you have time.
6e34f8b
to
eb0ca05
Compare
Description
Correctly detect direct dependencies when using
latest
version for filesyarn.lock
+package.json
.See #6747 for more details.
Related issues
latest
is used as a package version #6747Checklist