Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(k8s)!: node-collector dynamic commands support #6861

Merged
merged 10 commits into from
Jun 26, 2024
Merged

feat(k8s)!: node-collector dynamic commands support #6861

merged 10 commits into from
Jun 26, 2024

Conversation

chen-keinan
Copy link
Contributor

Description

feat: node-collector dynamic commands support

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).

@chen-keinan chen-keinan force-pushed the feat/node-collector-dynamic-commands-support branch 2 times, most recently from 9f70462 to aad30ea Compare June 6, 2024 14:45
@chen-keinan
Copy link
Contributor Author

@simar7 after bumping trivy-policies to v0.12.0 integration test. --> repo test are failing.

can you please have a look ?

@chen-keinan chen-keinan force-pushed the feat/node-collector-dynamic-commands-support branch 2 times, most recently from 035a164 to b3b856b Compare June 18, 2024 05:17
@chen-keinan chen-keinan force-pushed the feat/node-collector-dynamic-commands-support branch from 2aaf594 to 04aed3b Compare June 23, 2024 07:05
@chen-keinan chen-keinan changed the title feat: node-collector dynamic commands support BREAKING:: node-collector dynamic commands support Jun 23, 2024
@chen-keinan chen-keinan changed the title BREAKING:: node-collector dynamic commands support BREAKING: node-collector dynamic commands support Jun 23, 2024
@chen-keinan chen-keinan force-pushed the feat/node-collector-dynamic-commands-support branch 2 times, most recently from 45c9b8e to 894ef42 Compare June 23, 2024 13:10
@chen-keinan chen-keinan marked this pull request as ready for review June 23, 2024 13:44
@chen-keinan chen-keinan marked this pull request as draft June 23, 2024 13:44
@chen-keinan chen-keinan changed the title BREAKING: node-collector dynamic commands support feat(k8s)!: node-collector dynamic commands support Jun 24, 2024
@chen-keinan chen-keinan marked this pull request as ready for review June 25, 2024 07:21
@chen-keinan
Copy link
Contributor Author

@knqyf263 @simar7 @nikpivkin please review the PR and comment

@chen-keinan chen-keinan requested a review from nikpivkin June 25, 2024 08:33
@chen-keinan chen-keinan force-pushed the feat/node-collector-dynamic-commands-support branch from d0cecdf to 0ba9973 Compare June 25, 2024 10:35
@chen-keinan
docs: update cli
6fad5ba 
Signed-off-by: chenk <[email protected]>
nikpivkin
nikpivkin approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@nikpivkin nikpivkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@chen-keinan chen-keinan mentioned this pull request Jun 25, 2024
Merged
7 tasks
@simar7
Copy link
Member

simar7 commented Jun 25, 2024

@knqyf263 @simar7 @nikpivkin please review the PR and comment

I had created #7005 already but since you already bumped trivy-checks here, I will close the other one.

@simar7 simar7 mentioned this pull request Jun 25, 2024
Closed
6 tasks
@simar7 simar7 self-requested a review June 25, 2024 19:43
simar7
simar7 approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@simar7 simar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of nits but otherwise lgtm!

@chen-keinan
docs: typo fixes
e9b23a8 
Signed-off-by: chenk <[email protected]>
@chen-keinan chen-keinan requested review from knqyf263 June 26, 2024 05:38
@chen-keinan chen-keinan added this pull request to the merge queue Jun 26, 2024
Merged via the queue into aquasecurity:main with commit 8d618e4 Jun 26, 2024
17 checks passed
@chen-keinan chen-keinan deleted the feat/node-collector-dynamic-commands-support branch June 26, 2024 07:25
@aqua-bot aqua-bot mentioned this pull request Jun 26, 2024
Merged
skahn007gl pushed a commit to skahn007gl/trivy that referenced this pull request Jul 23, 2024
@chen-keinan @skahn007gl
feat(k8s)!: node-collector dynamic commands support (aquasecurity#6861)
ad77636 
Signed-off-by: chenk <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikpivkin nikpivkin nikpivkin approved these changes

@simar7 simar7 simar7 approved these changes

@knqyf263 knqyf263 Awaiting requested review from knqyf263 knqyf263 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node-collector: define and use trivy-checks commands
4 participants
@chen-keinan @simar7 @knqyf263 @nikpivkin