Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(go): include only .version|.ver (no prefixes) ldflags for gobinaries #6705

Merged

Conversation

DmitriyLewen
Copy link
Contributor

Description

There are cases when ldflags contain version with prefix (e.g. github.com/argoproj/argo-cd/v2/common.kubectlVersion=v0.26.11).
We don't need to take these versions.

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@DmitriyLewen DmitriyLewen self-assigned this May 16, 2024
@DmitriyLewen DmitriyLewen changed the title fix(golang): include only .version (no prefixes) ldflags for gobinaries fix(go): include only .version (no prefixes) ldflags for gobinaries May 16, 2024
@DmitriyLewen DmitriyLewen changed the title fix(go): include only .version (no prefixes) ldflags for gobinaries fix(go): include only .version|.ver (no prefixes) ldflags for gobinaries May 16, 2024
@DmitriyLewen DmitriyLewen marked this pull request as ready for review May 16, 2024 06:42
@DmitriyLewen DmitriyLewen requested a review from knqyf263 as a code owner May 16, 2024 06:42
@knqyf263
Copy link
Collaborator

I'll merge it, but we need an additional fix as I commented.
#6702 (comment)

@knqyf263 knqyf263 added this pull request to the merge queue May 17, 2024
Merged via the queue into aquasecurity:main with commit afb4f9d May 17, 2024
13 of 14 checks passed
@DmitriyLewen DmitriyLewen deleted the fix-gobinary/ldflags-version-prefix branch May 17, 2024 08:57
knqyf263 pushed a commit that referenced this pull request May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(gobinary): incorrect ldflags parsing when version part has prefix
2 participants