refactor(fanal): use const for environment.yaml

aquasecurity · Apr 27, 2024 · a3254f9 · a3254f9
1 parent 32b7ae2
commit a3254f9
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/pkg/fanal/analyzer/language/conda/environment/environment.go b/pkg/fanal/analyzer/language/conda/environment/environment.go
@@ -29,7 +29,7 @@ func (a environmentAnalyzer) Analyze(_ context.Context, input analyzer.AnalysisI
 	return res, nil
 }
 func (a environmentAnalyzer) Required(filePath string, _ os.FileInfo) bool {
-	return filepath.Base(filePath) == "environment.yaml" || filepath.Base(filePath) == "environment.yml"
+	return filepath.Base(filePath) == types.CondaEnvYml || filepath.Base(filePath) == types.CondaEnvYaml
 }
 
 func (a environmentAnalyzer) Type() analyzer.Type {

diff --git a/pkg/fanal/analyzer/language/conda/environment/environment_test.go b/pkg/fanal/analyzer/language/conda/environment/environment_test.go
@@ -36,8 +36,7 @@ func Test_environmentAnalyzer_Analyze(t *testing.T) {
 								},
 							},
 							{
-								Name:    "_openmp_mutex",
-								Version: "5.1",
+								Name: "_openmp_mutex",
 								Locations: []types.Location{
 									{
 										StartLine: 6,

diff --git a/pkg/fanal/types/const.go b/pkg/fanal/types/const.go
@@ -140,4 +140,7 @@ const (
 	PubSpecLock = "pubspec.lock"
 
 	MixLock = "mix.lock"
+
+	CondaEnvYaml = "environment.yaml"
+	CondaEnvYml  = "environment.yml"
 )