Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added AWS_REGION env for ECR images in the ClientServer mode #1613

Merged
merged 1 commit into from
Nov 4, 2023

Conversation

trublast
Copy link
Contributor

@trublast trublast commented Nov 3, 2023

Description

Scan pods can't pull images from ECR when AWS_REGION variable not set.
Added AWS_REGION environment variable for Amazon Elastic Container Registry images in the ClientServer mode

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@trublast trublast requested a review from chen-keinan as a code owner November 3, 2023 20:04
@CLAassistant
Copy link

CLAassistant commented Nov 3, 2023

CLA assistant check
All committers have signed the CLA.

@chen-keinan chen-keinan changed the title Added AWS_REGION env for ECR images in the ClientServer mode feat: Added AWS_REGION env for ECR images in the ClientServer mode Nov 4, 2023
@chen-keinan
Copy link
Contributor

@trublast lgtm 🚀 thank you for the contribution

@chen-keinan chen-keinan merged commit 9dbe998 into aquasecurity:main Nov 4, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants