feat: add default commands for unknown platform #409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi guys @simar7 @nikpivkin |
simar7
reviewed
Nov 1, 2024
Comment on lines
+256
to
+258
| want: &NodeCommands{ | ||
| Commands: commandsK8s, | ||
| }, |
There was a problem hiding this comment.
maybe add a comment saying why this gives us the k8s commands (because it is unknown). This would help with readability of the tests in the future.
There was a problem hiding this comment.
Actually, maybe it's better to just not use aks altogether as it may cause confusion. What if we just use unknown as a platform so it's more obvious that it doesn't exist?
There was a problem hiding this comment.
sure, aks is really bad.
done 3da704c
simar7
approved these changes
Nov 1, 2024
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds default command for unknown platforms.
the test cases was updated. I couldn't find
aksplatfrom in Trivy-check kubernetes commands: https://github.com/aquasecurity/trivy-checks/blob/main/commands/kubernetes/.so I've changed
akstorke2, and usingaksas unknown platform.Related issues