fix: add new status conditions for k8s v1.31 #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikpivkin
reviewed
Oct 17, 2024
| case batchv1.JobComplete, batchv1.JobSuccessCriteriaMet: | ||
| complete <- nil | ||
| return | ||
| case batchv1.JobFailed: |
There was a problem hiding this comment.
Should we also check the JobFailureTarget condition?
From the doc:
You can use the FailureTarget or the SuccessCriteriaMet condition to evaluate whether the Job has failed or succeeded without having to wait for the controller to add a terminal condition.
There was a problem hiding this comment.
good catch! I thought about it, but decided to wait for JobFailed. that means all pods are terminated.
to avoid an error aquasecurity/trivy#5639
wdyt?
nikpivkin
approved these changes
Oct 18, 2024
6 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Kubernetes v1.31.* the diagram of transitions looks like below.
so we can complete the job after the first success, but we should wait for all pods are terminated.
the docs: Transition of "status.conditions"