fix tests #6
Merged
fix tests #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nikpivkin could you take a look at reviewing this? |
nikpivkin
reviewed
Sep 19, 2023
test/docker_test.go
Outdated
| return nil | ||
| } | ||
|
|
||
| func Test_Docker_RegoPoliciesFromDisk(t *testing.T) { |
There was a problem hiding this comment.
This test loads Rego rules from the file system, but we moved the rules to another repo, so do we need this test? There are other tests that use custom rules.
There was a problem hiding this comment.
OK for the moment I've commented out until we figure out what we can (if anything) do with it. c8beec6
|
@simar7 I restarted the tests and they completed successfully. The problem was related to the terraform module cache (reproduced locally). We can add a new option for terraform parser that will disallow using the cache to load modules. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.