Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vulnsrc/nvd): add CVSS v4.0 #414

Merged
merged 2 commits into from
Jul 5, 2024
Merged

Conversation

MaineK00n
Copy link
Contributor

Description

Supports NVD CVSS V4.0 Schema with Trivy DB.
aquasecurity/vuln-list-update#297

How has this been tested?

I've run the test cases using make test and all of them passed.

@MaineK00n MaineK00n marked this pull request as ready for review July 1, 2024 03:13
@MaineK00n MaineK00n requested a review from knqyf263 as a code owner July 1, 2024 03:13
pkg/vulnsrc/nvd/nvd.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@knqyf263 knqyf263 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (tests are failing, though). @DmitriyLewen Can you please double-check this PR?

Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knqyf263
Copy link
Collaborator

knqyf263 commented Jul 5, 2024

I wanted to test it on real data, but I could not do it since NVD only publishes CVSSv4 scored by other CNAs and has not yet published CVSSv4 by NVD itself. However, I think the implementation is good and will merge it.

@knqyf263 knqyf263 merged commit e94dc82 into aquasecurity:main Jul 5, 2024
2 checks passed
@DmitriyLewen
Copy link
Contributor

I could not do it since NVD only publishes CVSSv4 scored by other CNAs and has not yet published CVSSv4 by NVD itself

I saw it too. I renamed source field in few CVE files (to test) and it worked well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants