Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added openSUSE Tumbleweed version detection #411

Merged
merged 6 commits into from
Jun 26, 2024

Conversation

msmeissn
Copy link
Contributor

(Tumbleweed has no version as it is rolling)

#410

@msmeissn msmeissn requested a review from knqyf263 as a code owner June 19, 2024 08:33
@CLAassistant
Copy link

CLAassistant commented Jun 19, 2024

CLA assistant check
All committers have signed the CLA.

msmeissn added a commit to msmeissn/trivy that referenced this pull request Jun 19, 2024
(Tumbleweed has no version as it is rolling)

aquasecurity#410
msmeissn added a commit to msmeissn/trivy that referenced this pull request Jun 19, 2024
@msmeissn msmeissn force-pushed the main branch 2 times, most recently from 3eec1fc to f055a59 Compare June 19, 2024 11:55
msmeissn added a commit to msmeissn/trivy that referenced this pull request Jun 19, 2024
msmeissn added a commit to msmeissn/trivy that referenced this pull request Jun 19, 2024
Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @msmeissn
Thanks for your work!

LGTM, but add test for openSUSE Tumbleweed please.

UPD:
Fix linter errors, please.

@msmeissn
Copy link
Contributor Author

will do

@msmeissn
Copy link
Contributor Author

I got it make lint clean.

I added a openSUSE Tumbleweed testcase, "make check" works (only FAILS in the GHSA parts).

@knqyf263 knqyf263 requested a review from DmitriyLewen June 21, 2024 18:14
Copy link
Contributor

@DmitriyLewen DmitriyLewen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@knqyf263 take a look, when you have time, please

@knqyf263
Copy link
Collaborator

@DmitriyLewen Did you build trivy-db and it looked fine?

@DmitriyLewen
Copy link
Contributor

Yes. Looks good.
openSUSE Tumbleweed contains a lot of buckets, but I've now rechecked and it looks as expected.
Screenshot from 2024-06-26 10-02-14

@knqyf263
Copy link
Collaborator

Oh, 17,376 buckets. How about the database size?

@DmitriyLewen
Copy link
Contributor

  • 0.6 MB before unzip
  • 16 MB after unzip
➜  ls -l ./assets    
total 517492
-rw-rw-r-- 1 dmitriy dmitriy  51106757 июн 26 12:34 db.tar.gz
-rw-rw-r-- 1 dmitriy dmitriy       143 июн 26 12:34 metadata.json
-rw------- 1 dmitriy dmitriy 480534528 июн 26 12:34 trivy.db
➜  ls -l ./assets-new
total 536156
-rw-rw-r-- 1 dmitriy dmitriy  51696853 июн 26 12:13 db.tar.gz
-rw-rw-r-- 1 dmitriy dmitriy       143 июн 26 09:59 metadata.json
-rw------- 1 dmitriy dmitriy 497311744 июн 26 09:59 trivy.db

@knqyf263
Copy link
Collaborator

  • 0.6 MB before unzip
  • 16 MB after unzip
➜  ls -l ./assets    
total 517492
-rw-rw-r-- 1 dmitriy dmitriy  51106757 июн 26 12:34 db.tar.gz
-rw-rw-r-- 1 dmitriy dmitriy       143 июн 26 12:34 metadata.json
-rw------- 1 dmitriy dmitriy 480534528 июн 26 12:34 trivy.db
➜  ls -l ./assets-new
total 536156
-rw-rw-r-- 1 dmitriy dmitriy  51696853 июн 26 12:13 db.tar.gz
-rw-rw-r-- 1 dmitriy dmitriy       143 июн 26 09:59 metadata.json
-rw------- 1 dmitriy dmitriy 497311744 июн 26 09:59 trivy.db

Looks reasonable.

@knqyf263 knqyf263 merged commit 27fa703 into aquasecurity:main Jun 26, 2024
2 checks passed
msmeissn added a commit to msmeissn/trivy that referenced this pull request Jun 26, 2024
an1kelesh added a commit to an1kelesh/trivy-db that referenced this pull request Jun 27, 2024
added openSUSE Tumbleweed version detection (aquasecurity#411)
msmeissn added a commit to msmeissn/trivy that referenced this pull request Jul 3, 2024
msmeissn added a commit to msmeissn/trivy that referenced this pull request Jul 5, 2024
msmeissn added a commit to msmeissn/trivy that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants