tests: Re add scanner_test.go #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nikpivkin can you take a look? |
nikpivkin
reviewed
Sep 21, 2023
| "io/fs" | ||
| "testing" | ||
|
|
||
| "github.com/aquasecurity/defsec/pkg/providers/azure" |
There was a problem hiding this comment.
We should not have a dependency on azure. Isn't it?
There was a problem hiding this comment.
yes but it's part of a multi cloud test that today lives here
trivy-aws/pkg/scanner/scanner_test.go
Line 358 in bc16385
nikpivkin
reviewed
Sep 21, 2023
pkg/scanner/options.go
Outdated
| @@ -1,7 +1,7 @@ | |||
| package scanner | |||
|
|
|||
| import ( | |||
| "github.com/aquasecurity/defsec/pkg/scanners/options" | |||
| "github.com/aquasecurity/trivy-iac/pkg/scanners/options" | |||
There was a problem hiding this comment.
Should we have trivy-iac as a dependency?
There was a problem hiding this comment.
hmm yeah maybe the options package needs to be abstracted out of trivy-iac as well to a common place. What do you think?
There was a problem hiding this comment.
I updated it here ba16ec1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.