Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ebpf): make ptrace no rely on sys_enter/exit #4231

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions pkg/ebpf/c/tracee.bpf.c
Original file line number Diff line number Diff line change
Expand Up @@ -5133,6 +5133,31 @@ int BPF_KPROBE(trace_security_task_setrlimit)
return events_perf_submit(&p, 0);
}

SEC("kretprobe/ptrace")
int BPF_KPROBE(trace_ptrace)
{
program_data_t p = {};
if (!init_program_data(&p, ctx, PTRACE_NO_SYS_ENTER))
return 0;

if (!evaluate_scope_filters(&p))
return 0;

struct pt_regs *task_regs = get_current_task_pt_regs();
long request = get_syscall_arg1(p.event->task, task_regs, false);
pid_t pid = get_syscall_arg2(p.event->task, task_regs, false);
void *addr = (void *) get_syscall_arg3(p.event->task, task_regs, false);
void *data = (void *) get_syscall_arg4(p.event->task, task_regs, false);

save_to_submit_buf(&p.event->args_buf, &request, sizeof(long), 0);
save_to_submit_buf(&p.event->args_buf, &pid, sizeof(pid_t), 1);
save_to_submit_buf(&p.event->args_buf, &addr, sizeof(void *), 2);
save_to_submit_buf(&p.event->args_buf, &data, sizeof(void *), 3);

int ret = PT_REGS_RC(ctx);
return events_perf_submit(&p, ret);
}

SEC("kprobe/security_settime64")
int BPF_KPROBE(trace_security_settime64)
{
Expand Down
1 change: 1 addition & 0 deletions pkg/ebpf/c/types.h
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,7 @@ enum event_id_e
SECURITY_BPRM_CREDS_FOR_EXEC,
SECURITY_TASK_SETRLIMIT,
SECURITY_SETTIME64,
PTRACE_NO_SYS_ENTER,
MAX_EVENT_ID,
NO_EVENT_SUBMIT,

Expand Down
4 changes: 4 additions & 0 deletions pkg/ebpf/probes/probe_group.go
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,10 @@ func NewDefaultProbeGroup(module *bpf.Module, netEnabled bool) (*ProbeGroup, err
ExecuteAtFinishedCompatARM: NewTraceProbe(KretProbe, "__arm64_compat_sys_execveat", "trace_execute_finished"),
SecurityTaskSetrlimit: NewTraceProbe(KProbe, "security_task_setrlimit", "trace_security_task_setrlimit"),
SecuritySettime64: NewTraceProbe(KProbe, "security_settime64", "trace_security_settime64"),
PtraceX86: NewTraceProbe(KretProbe, "__x64_sys_ptrace", "trace_ptrace"),
PtraceCompatX86: NewTraceProbe(KretProbe, "__ia32_compat_sys_ptrace", "trace_ptrace"),
PtraceARM: NewTraceProbe(KretProbe, "__arm64_sys_ptrace", "trace_ptrace"),
PtraceCompatARM: NewTraceProbe(KretProbe, "__arm64_compat_sys_ptrace", "trace_ptrace"),

TestUnavailableHook: NewTraceProbe(KProbe, "non_existing_func", "empty_kprobe"),
ExecTest: NewTraceProbe(RawTracepoint, "raw_syscalls:sched_process_exec", "tracepoint__exec_test"),
Expand Down
4 changes: 4 additions & 0 deletions pkg/ebpf/probes/probes.go
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,10 @@ const (
ExecuteAtFinishedCompatARM
SecurityTaskSetrlimit
SecuritySettime64
PtraceX86
PtraceCompatX86
PtraceARM
PtraceCompatARM
)

// Test probe handles
Expand Down
49 changes: 23 additions & 26 deletions pkg/events/core.go
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,7 @@ const (
SecurityBprmCredsForExec
SecurityTaskSetrlimit
SecuritySettime64
PtraceSyscallNoSysenter
MaxCommonID
)

Expand Down Expand Up @@ -2675,32 +2676,6 @@ var CoreEvents = map[ID]Definition{
},
},
},
Ptrace: {
id: Ptrace,
id32Bit: Sys32ptrace,
name: "ptrace",
version: NewVersion(1, 0, 0),
syscall: true,
sets: []string{"default", "syscalls", "proc"},
params: []trace.ArgMeta{
{Type: "long", Name: "request"},
{Type: "pid_t", Name: "pid"},
{Type: "void*", Name: "addr"},
{Type: "void*", Name: "data"},
},
dependencies: Dependencies{
probes: []Probe{
{handle: probes.SyscallEnter__Internal, required: true},
{handle: probes.SyscallExit__Internal, required: true},
},
tailCalls: []TailCall{
{"sys_enter_init_tail", "sys_enter_init", []uint32{uint32(Ptrace)}},
{"sys_enter_submit_tail", "sys_enter_submit", []uint32{uint32(Ptrace)}},
{"sys_exit_init_tail", "sys_exit_init", []uint32{uint32(Ptrace)}},
{"sys_exit_submit_tail", "sys_exit_submit", []uint32{uint32(Ptrace)}},
},
},
},
Getuid: {
id: Getuid,
id32Bit: Sys32getuid32,
Expand Down Expand Up @@ -13106,6 +13081,28 @@ var CoreEvents = map[ID]Definition{
{Type: "int", Name: "tz_dsttime"},
},
},
PtraceSyscallNoSysenter: {
id: PtraceSyscallNoSysenter,
id32Bit: Sys32ptrace,
name: "ptrace",
version: NewVersion(1, 0, 0),
syscall: true,
sets: []string{"default", "syscalls", "proc"},
params: []trace.ArgMeta{
{Type: "long", Name: "request"},
{Type: "pid_t", Name: "pid"},
{Type: "void*", Name: "addr"},
{Type: "void*", Name: "data"},
},
dependencies: Dependencies{
probes: []Probe{
{handle: probes.PtraceX86, required: false},
{handle: probes.PtraceCompatX86, required: false},
{handle: probes.PtraceARM, required: false},
{handle: probes.PtraceCompatARM, required: false},
},
},
},
//
// Begin of Signal Events (Control Plane)
//
Expand Down
2 changes: 1 addition & 1 deletion pkg/events/parse_args.go
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ func ParseArgs(event *trace.Event) error {
parseOrEmptyString(prevProtArg, mmapProtArgument, nil)
}
}
case Ptrace:
case PtraceSyscallNoSysenter:
if reqArg := GetArg(event, "request"); reqArg != nil {
if req, isInt64 := reqArg.Value.(int64); isInt64 {
ptraceRequestArgument, err := parsers.ParsePtraceRequestArgument(uint64(req))
Expand Down
Loading