optimize parser options check #4199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geyslan
force-pushed
the
optimize-parsers
branch
from
633a3d4 to
45cd736
Compare
geyslan
changed the title
geyslan
changed the title
geyslan
force-pushed
the
optimize-parsers
branch
from
1dfbe87 to
6b9fbf6
Compare
geyslan
commented
Aug 14, 2024
| @@ -1466,7 +1474,7 @@ func ParseMmapProt(rawValue uint64) MmapProtArgument { | |||
|
|
|||
| var sb strings.Builder | |||
| for _, a := range mmapProtArgs { | |||
| if OptionAreContainedInArgument(rawValue, a) { | |||
| if optionIsContainedInArgument(rawValue, a.Value()) { | |||
There was a problem hiding this comment.
ParseMmapProt already iterates its arguments. In the future, the loop approach can be applied to the other parser functions. Despite the improvement in CPU time the only criticism is that we need a global variable containing all arguments. But I believe this can be improved further by using pointers to existing declarations.
geyslan
force-pushed
the
optimize-parsers
branch
from
6b9fbf6 to
8b98236
Compare
Optimize OptionsAreContainedInArgument function to return as soon as it detects a non-contained option. Running tool: /home/gg/.goenv/versions/1.22.4/bin/go test -benchmem -run=^$ -tags ebpf -bench ^(BenchmarkOptionsAreContainedInArgumentOld|BenchmarkOptionsAreContainedInArgument)$ github.com/aquasecurity/tracee/pkg/events/parsers -benchtime=1000000x -race goos: linux goarch: amd64 pkg: github.com/aquasecurity/tracee/pkg/events/parsers cpu: AMD Ryzen 9 7950X 16-Core Processor === RUN BenchmarkOptionsAreContainedInArgumentOld BenchmarkOptionsAreContainedInArgumentOld BenchmarkOptionsAreContainedInArgumentOld-32 1000000 500.4 ns/op 0 B/op 0 allocs/op === RUN BenchmarkOptionsAreContainedInArgument BenchmarkOptionsAreContainedInArgument BenchmarkOptionsAreContainedInArgument-32 1000000 351.3 ns/op 0 B/op 0 allocs/op PASS ok github.com/aquasecurity/tracee/pkg/events/parsers 1.861s
optionsAreContainedInArgument now receives a variadic argument of type uint64 instead of SystemFunctionArgument. === RUN BenchmarkOptionsAreContainedInArgumentPrev BenchmarkOptionsAreContainedInArgumentPrev BenchmarkOptionsAreContainedInArgumentPrev-32 5000000 387.7 ns/op 0 B/op 0 allocs/op === RUN BenchmarkOptionsAreContainedInArgument BenchmarkOptionsAreContainedInArgument BenchmarkOptionsAreContainedInArgument-32 5000000 152.3 ns/op 0 B/op
Currently all usages of the `optionsAreContainedInArgument` function are using only one option. Then, `optionIsContainedInArgument` comes as a simplification of the previous function. Even though `optionsAreContainedInArgument` is not used anymore, it is still being kept for now, since some parser might need to check for multiple options in the future. === RUN Benchmark_optionsAreContainedInArgumentWithOnlyOne Benchmark_optionsAreContainedInArgumentWithOnlyOne Benchmark_optionsAreContainedInArgumentWithOnlyOne-32 5000000 174.8 ns/op 0 B/op 0 allocs/op === RUN Benchmark_optionIsContainedInArgument Benchmark_optionIsContainedInArgument Benchmark_optionIsContainedInArgument-32 5000000 140.4 ns/op 0 B/op 0 allocs/op PASS
geyslan
force-pushed
the
optimize-parsers
branch
from
8b98236 to
d7fa48d
Compare
|
double check the benchmarks and its aligned with yours: impr OptionsAreContainedInArgument: opti optionsAreContainedInArgument: add optionIsContainedInArgument: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Explain what the PR does
d7fa48d chore(parsers): add optionIsContainedInArgument
c830bf9 chore(parsers): opti optionsAreContainedInArgument
b15d559 chore(parsers): impr OptionsAreContainedInArgument
d7fa48d chore(parsers): add optionIsContainedInArgument
c830bf9 chore(parsers): opti optionsAreContainedInArgument
b15d559 chore(parsers): impr OptionsAreContainedInArgument
2. Explain how to test it
3. Other comments